Re: [PATCH 5/6] dt-bindings: phy-qcom-usb2: Update bindings for sdm845

[Manu Gautam]

Hi,


On 3/20/2018 3:53 PM, Vivek Gautam wrote:
> Hi Manu,
>
>
> On 3/16/2018 3:14 PM, Manu Gautam wrote:
>> Update compatible strings for USB2 PHYs on sdm845.
>> There are two QUSB2 PHYs present on sdm845. Few PHY registers
>> programming is different for these PHYs related to electrical
>> parameters, otherwise both are same.
>>
>> Signed-off-by: Manu Gautam <mgautam@xxxxxxxxxxxxxx>
>> ---
>> Â Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++-
>> Â 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
>> index 42c9742..20deaeb 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
>> +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
>> @@ -6,7 +6,9 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets.
>> Â Required properties:
>> ÂÂ - compatible: compatible list, contains
>> ÂÂÂÂÂÂÂÂÂÂÂÂ "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996,
>> -ÂÂÂÂÂÂÂÂÂÂ "qcom,qusb2-v2-phy" for QUSB2 V2 PHY.
>> +ÂÂÂÂÂÂÂÂÂÂ "qcom,qusb2-v2-phy" for QUSB2 V2 PHY,
>> +ÂÂÂÂÂÂÂÂÂÂ "qcom,sdm845-1-qusb2-phy" for primary PHY on sdm845,
>> +ÂÂÂÂÂÂÂÂÂÂ "qcom,sdm845-2-qusb2-phy" for secondary PHY on sdm845.
>
> Thanks for the patch.
>
> "qcom,sdm845-1/2-qusb2-phy" gives an impression that it is different versions of SoC,
> and not like two numbers of phy.
> May be - "qcom,sdm845-qusb2-phy-1/2"

I agree with that. Will update.

>
> Regards
> Vivek
> Â
>
>> Â ÂÂ - reg: offset and length of the PHY register set.
>> ÂÂ - #phy-cells: must be 0.
>

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project