[PATCH v2] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe()

From: Alban Bedel
Date: Sat Mar 24 2018 - 19:49:54 EST


From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>

platform_get_resource() may return NULL, add proper
check to avoid potential NULL dereferencing.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
[albeu@xxxxxxx: Fixed patch to apply on current tree]
Signed-off-by: Alban Bedel <albeu@xxxxxxx>
---
drivers/gpio/gpio-ath79.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index 3ae7c18..684e9d6 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -258,6 +258,8 @@ static int ath79_gpio_probe(struct platform_device *pdev)
}

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res)
+ return -EINVAL;
ctrl->base = devm_ioremap_nocache(
&pdev->dev, res->start, resource_size(res));
if (!ctrl->base)
--
2.7.4