Re: [PATCH v2] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe()

[Linus Walleij]

On Sun, Mar 25, 2018 at 12:40 AM, Alban Bedel <albeu@xxxxxxx> wrote:

> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> platform_get_resource() may return NULL, add proper
> check to avoid potential NULL dereferencing.
>
> This is detected by Coccinelle semantic patch.
>
> @@
> expression pdev, res, n, t, e, e1, e2;
> @@
>
> res = platform_get_resource(pdev, t, n);
> + if (!res)
> +   return -EINVAL;
> ... when != res == NULL
> e = devm_ioremap(e1, res->start, e2);
>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> [albeu@xxxxxxx: Fixed patch to apply on current tree]
> Signed-off-by: Alban Bedel <albeu@xxxxxxx>

Patch applied.

Yours,
Linus Walleij