Re: [PATCH] genirq: Pass desc to __irq_free instead of irq number

From: Uwe Kleine-König
Date: Sun Mar 25 2018 - 18:12:20 EST


Hello,

On Mon, Mar 19, 2018 at 11:52:02AM +0100, Uwe Kleine-König wrote:
> Given that irq_to_desc() is a radix_tree_lookup and the reverse
> operation is only a pointer dereference and that all callers of
> __free_irq already have the desc, pass the desc instead of the irq
> number.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> Hello,
>
> this is a micro optimisation I noticed while looking at the irq code.

This made it into next as 83ac4ca943affce56a2c408ddb2f5232f478fb11 and
ba63053f018721a0ad60b083e21a15e324a4a8c4. Is it right that it is there
twice? And in the Author line the - in my name is missing. Would be
great if that could be fixed up.

Something like:

git filter-branch -f --env-filter 'test "$GIT_AUTHOR_NAME" != "Uwe Kleine König" || GIT_AUTHOR_NAME="Uwe Kleine-König"' linus/master..

should do the trick.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |