Re: [PATCH v4 2/9] vsprintf: Consistent %pK handling for kptr_restrict == 0

From: Andy Shevchenko
Date: Thu Apr 05 2018 - 09:04:56 EST


On Wed, 2018-04-04 at 10:58 +0200, Petr Mladek wrote:
> restricted_pointer() pretends that it prints the address when
> kptr_restrict
> is set to zero. But it is never called in this situation. Instead,
> pointer() falls back to ptr_to_id() and hashes the pointer.
>
> This patch removes the potential confusion. klp_restrict is checked
> only
> in restricted_pointer().
>


> /* Maps a pointer to a 32 bit unique identifier. */
> -static char *ptr_to_id(char *buf, char *end, void *ptr, struct
> printf_spec spec)
> +static char *ptr_to_id(char *buf, char *end,
> + const void *ptr, struct printf_spec spec)

I don't think this change belongs to the patch.


--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy