Re: [PATCH v2 3/5] ASoC: max9860: switch to SPDX license tag

From: Christoph Hellwig
Date: Sun Apr 15 2018 - 03:39:01 EST


On Fri, Apr 13, 2018 at 12:19:27PM +0100, Mark Brown wrote:
> On Thu, Apr 12, 2018 at 11:14:35PM +0200, Peter Rosin wrote:
>
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > /*
> > * Driver for the MAX9860 Mono Audio Voice Codec
> > *
>
> Please don't mix C and C++ comments like this - it looks unintentional
> and messy. Just convert the entire comment block to C++ so it's
> consistent with itself.

NAK - that is exactky the wrong way to go. Normal Linux comments are
classi C-style comments and should remain so. SPDX tags use c++
comments exactly to be different and stick out.



---end quoted text---