Re: [PATCH] net: wireless: ti: wlcore: sdio: allow pm to handle sdio power

From: Tony Lindgren
Date: Wed Apr 25 2018 - 09:56:00 EST


* Eyal Reizer <eyalreizer@xxxxxxxxx> [180425 13:43]:
> pm_runtime handles sdio power on and power off transitions.
> An old workaround for trying to control the power explicitly from the
> driver was in fact causing failures on suspend/resume as the mmc layer
> already power the module on resume.
>
> In case of resume pm_runtime_get sync returns a positive device's usage
> count causing the driver to try an re-initialize an already initialized
> device. This was causing sdio bus failure on resume.
>
> Remove this manual power on/off sequence as it is in-fact not needed.
>
> Signed-off-by: Eyal Reizer <eyalr@xxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

Stable cc dropped, see Documentation/process/stable-kernel-rules.rst.

Looks good to me:

Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>