Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

From: Oleg Nesterov
Date: Wed Apr 25 2018 - 09:56:06 EST


On 04/24, Eric W. Biederman wrote:
>
> Let me respectfully suggest that the wait_event_killable on that code
> path is wrong.

I tend to agree even if I don't know this code.

But if it can be called from f_op->release() then any usage of "current" or
signals looks suspicious. Simply because "current" can be completely irrelevant
task which does the last fput(), say, cat /proc/pid/fdinfo/... or even a kernel
thread.

Oleg.