Re: [PATCH] MAINTAINERS: add myself as maintainer of AFFS

From: Linus Torvalds
Date: Sat Apr 28 2018 - 13:34:16 EST


On Sat, Apr 28, 2018 at 10:07 AM David Sterba <dsterba@xxxxxxxx> wrote:

> I volunteer to act as a maintainer of AFFS to collect any fixes that
> might show up and to guard fs/affs/ against another spring cleaning.

Hmm. Please be more careful.

> @@ -564,8 +564,10 @@ S: Maintained

The above says it adds two lines (8 -> 10), but the actual patch itself
only adds one, and modifies another:

> +M: David Sterba <dsterba@xxxxxxxx>
> -S: Orphan
> +S: Odd Fixes

I'm used to editing patches for things like this, because I have years and
years of just hand-editing patches I didn't like for some reason, but it
looks like you tried to edit a patch without knowing all the rules for how
unified patches work.

So please don't edit patches by hand. It's a skill nobody should have.

Anyway, I fixed the patch and applied it, but let's not make a habit of it.

Linus