Re: [PATCH] MAINTAINERS: add myself as maintainer of AFFS
From: David Sterba
Date: Sat Apr 28 2018 - 14:01:39 EST
On Sat, Apr 28, 2018 at 05:33:57PM +0000, Linus Torvalds wrote:
> On Sat, Apr 28, 2018 at 10:07 AM David Sterba <dsterba@xxxxxxxx> wrote:
> > I volunteer to act as a maintainer of AFFS to collect any fixes that
> > might show up and to guard fs/affs/ against another spring cleaning.
> Hmm. Please be more careful.
> > @@ -564,8 +564,10 @@ S: Maintained
> The above says it adds two lines (8 -> 10), but the actual patch itself
> only adds one, and modifies another:
> > +M: David Sterba <dsterba@xxxxxxxx>
> > -S: Orphan
> > +S: Odd Fixes
> I'm used to editing patches for things like this, because I have years and
> years of just hand-editing patches I didn't like for some reason, but it
> looks like you tried to edit a patch without knowing all the rules for how
> unified patches work.
> So please don't edit patches by hand. It's a skill nobody should have.
> Anyway, I fixed the patch and applied it, but let's not make a habit of it.
Sorry, it was a last minute change. There was a T: line with a git tree
reference, but this looked odd and I deleted it, but did not realize the
patch would not apply. Too excited to send it.