Re: [PATCH 0/6] use memcpy_mcsafe() for copy_to_iter()
From: Linus Torvalds
Date: Tue May 01 2018 - 17:06:06 EST
On Tue, May 1, 2018 at 1:55 PM Dan Williams <dan.j.williams@xxxxxxxxx>
wrote:
> The result of the bypass is that the kernel treats machine checks during
> read as system fatal (reboot) when they could simply be flagged as an
> I/O error, similar to performing reads through the pmem driver. Prevent
> this fatal condition by deploying memcpy_mcsafe() in the fsdax read
> path.
How about just changing the rules, and go the old "Don't do that then" way?
IOW, get rid of the whole idea that MCS errors should be fatal. It's wrong
and pointless anyway.
The while approach seems fundamentally buggered, if you ever want to mmap
one of these things. And don't you want that?
So why continue down a fundamentally broken path?
Linus