Re: [Ksummit-discuss] bug-introducing patches

From: Theodore Y. Ts'o
Date: Fri May 04 2018 - 17:13:37 EST


On Fri, May 04, 2018 at 10:40:55AM -0700, Greg KH wrote:
> Ugh, what? I don't understand what you are proposing here, what we have
> today is just fine, what is broken with it?

What we have today is this:

Cc: stable@xxxxxxxxxx # 3.11
Cc: stable@xxxxxxxxxx # 4.8+
Cc: stable@xxxxxxxxxx # 4.8+

Jani was suggesting something documented which doesn't match current
practice. See commit 8e9b9362266d, which describes something like this:

Cc: <stable@xxxxxxxxxx> # .32.x: a1f84a3: sched: Check for idle
Cc: <stable@xxxxxxxxxx> # .32.x: 1b9508f: sched: Rate-limit newidle
Cc: <stable@xxxxxxxxxx> # .32.x: fd21073: sched: Fix affinity logic

... to specify prereqisite commits needed to backport the commit in
question. I am proposing that we delete what is in
stable_kernel_rules.rst, because it doesn't match with current
practice.

If it is necessary to explicitly specify prerequisites (as opposed to
having scripts or stable maintainers guess or figure things out
manually), then something like this might be better:

Stable-prereq: DEADBEEF1234: subsystem: bork bork bork....

If it's not necessary, fine. But we should still delete what is
currently documented in stable_kernel_rules and was introduced in
8e9b9362266d, because it doesn't describe current practice.

- Ted