Re: [PATCH v5 0/7] pcal6524 extensions and fixes for pca953x driver

From: H. Nikolaus Schaller
Date: Wed May 16 2018 - 08:59:55 EST


Hi,

> Am 16.05.2018 um 13:53 schrieb Linus Walleij <linus.walleij@xxxxxxxxxx>:
>
> On Sat, Apr 28, 2018 at 6:31 PM, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> wrote:
>
>> V5:
>> * fix wrong split up between patches 1/7and 2/7.
>
> I applied patches 1, 2, 3 so we get some movement on the patch
> set and not too much for you to rebase.

thanks!

Well, I already had edited the commit messages for resending...

>
> It's fine to just resend the rest next time.

There is only one point open before resending:

what is the preferred style to be used for PCAL_GPIO_MASK?

* GENMASK(4, 0)
* or 0x1f

BR,
Nikolaus