Re: [PATCH 4.4 60/97] clk: mvebu: armada-38x: add support for 1866MHz variants

[Ben Hutchings]

On Sun, 2018-04-22 at 15:53 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx>
> 
> commit 9593f4f56cf5d1c443f66660a0c7f01de38f979d upstream.
> 
> The Linksys WRT3200ACM CPU is clocked at 1866MHz. Add 1866MHz to the
> list of supported CPU frequencies. Also update multiplier and divisor
> for the l2clk and ddrclk.
> 
> Noticed by the following warning:
> [ÂÂÂÂ0.000000] Selected CPU frequency (16) unsupported

So the frequency selection field is read as 16...

[...]
> --- a/drivers/clk/mvebu/armada-38x.c
> +++ b/drivers/clk/mvebu/armada-38x.c
> @@ -49,7 +49,8 @@ static const u32 armada_38x_cpu_frequenc
> Â	0, 0, 0, 0,
> Â	1066 * 1000 * 1000, 0, 0, 0,
> Â	1332 * 1000 * 1000, 0, 0, 0,
> -	1600 * 1000 * 1000,
> +	1600 * 1000 * 1000, 0, 0, 0,
> +	1866 * 1000 * 1000,
> Â};
[...]

...but this only adds entries to the lookup table at indexes 9-12
inclusive.

It looks like this fixes the clock settings, but not the warning.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.