Re: [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version

From: David Miller
Date: Thu May 17 2018 - 15:34:40 EST


From: Andrea Greco <andrea.greco.gapmilano@xxxxxxxxx>
Date: Thu, 17 May 2018 15:05:29 +0200

> + /* Will be set by userspace during if setup */
> + dev->dev_addr[0] = 0;

Hmmm... really?

Also, every error path from this point forward will leak 'dev'.