Re: [PATCH 4.14 110/165] scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte()

[Steffen Maier]

Hopefully I haven't missed it in the stable queue, but do we need the 
following on top (effectively not applying e39a97353e53)?:

commit cbe095e2b584623b882ebaf6c18e0b9077baa3f7
Author: Bart Van Assche <bart.vanassche@xxxxxxx>
Date:   Thu Apr 5 10:32:59 2018 -0700

    Revert "scsi: core: return BLK_STS_OK for DID_OK in 
__scsi_error_from_host_byte()"

    The description of commit e39a97353e53 is wrong: it mentions that 
commit
    2a842acab109 introduced a bug in __scsi_error_from_host_byte() 
although that
    commit did not change the behavior of that function.  Additionally, 
commit
    e39a97353e53 introduced a bug: it causes commands that fail with
    hostbyte=DID_OK and driverbyte=DRIVER_SENSE to be completed with
    BLK_STS_OK. Hence revert that commit.

    Fixes: e39a97353e53 ("scsi: core: return BLK_STS_OK for DID_OK in 
__scsi_error_from_host_byte()")
    Reported-by: Damien Le Moal <damien.lemoal@xxxxxxx>
    Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
    Cc: Hannes Reinecke <hare@xxxxxxxx>
    Cc: Douglas Gilbert <dgilbert@xxxxxxxxxxxx>
    Cc: Damien Le Moal <damien.lemoal@xxxxxxx>
    Cc: Christoph Hellwig <hch@xxxxxx>
    Cc: Lee Duncan <lduncan@xxxxxxxx>
    Cc: stable@xxxxxxxxxxxxxxx
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
    Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>


On 05/24/2018 11:38 AM, Greg Kroah-Hartman wrote:
> 4.14-stable review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Hannes Reinecke <hare@xxxxxxx>
>
> [ Upstream commit e39a97353e5378eb46bf01679799c5704d397f32 ]
>
> When converting __scsi_error_from_host_byte() to BLK_STS error codes the
> case DID_OK was forgotten, resulting in it always returning an error.
>
> Fixes: 2a842acab109 ("block: introduce new block status code type")
> Cc: Doug Gilbert <dgilbert@xxxxxxxxxxxx>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxxx>
> Reviewed-by: Douglas Gilbert <dgilbert@xxxxxxxxxxxx>
> Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>   drivers/scsi/scsi_lib.c |    2 ++
>   1 file changed, 2 insertions(+)
>
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -720,6 +720,8 @@ static blk_status_t __scsi_error_from_ho
>   		int result)
>   {
>   	switch (host_byte(result)) {
> +	case DID_OK:
> +		return BLK_STS_OK;
>   	case DID_TRANSPORT_FAILFAST:
>   		return BLK_STS_TRANSPORT;
>   	case DID_TARGET_FAILURE:


--
Mit freundlichen Gruessen / Kind regards
Steffen Maier

Linux on IBM Z Development

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294