Re: [PATCH 4.14 110/165] scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte()

[Greg Kroah-Hartman]

On Thu, May 24, 2018 at 02:19:29PM +0200, Steffen Maier wrote:
> Hopefully I haven't missed it in the stable queue, but do we need the
> following on top (effectively not applying e39a97353e53)?:
> 
> commit cbe095e2b584623b882ebaf6c18e0b9077baa3f7
> Author: Bart Van Assche <bart.vanassche@xxxxxxx>
> Date:   Thu Apr 5 10:32:59 2018 -0700
> 
>     Revert "scsi: core: return BLK_STS_OK for DID_OK in
> __scsi_error_from_host_byte()"
> 
>     The description of commit e39a97353e53 is wrong: it mentions that commit
>     2a842acab109 introduced a bug in __scsi_error_from_host_byte() although
> that
>     commit did not change the behavior of that function.  Additionally,
> commit
>     e39a97353e53 introduced a bug: it causes commands that fail with
>     hostbyte=DID_OK and driverbyte=DRIVER_SENSE to be completed with
>     BLK_STS_OK. Hence revert that commit.
> 
>     Fixes: e39a97353e53 ("scsi: core: return BLK_STS_OK for DID_OK in
> __scsi_error_from_host_byte()")
>     Reported-by: Damien Le Moal <damien.lemoal@xxxxxxx>
>     Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
>     Cc: Hannes Reinecke <hare@xxxxxxxx>
>     Cc: Douglas Gilbert <dgilbert@xxxxxxxxxxxx>
>     Cc: Damien Le Moal <damien.lemoal@xxxxxxx>
>     Cc: Christoph Hellwig <hch@xxxxxx>
>     Cc: Lee Duncan <lduncan@xxxxxxxx>
>     Cc: stable@xxxxxxxxxxxxxxx
>     Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>     Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
>     Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

Oops, yeah, I'll go drop this one from the queue, we shouldn't take it
at all, as that's easier than applying it and then reverting it again.

Thanks for letting me know.

greg k-h