Re: [PATCH V2 net] net: hns: Fix the process of adding broadcast addresses to tcam

From: David Miller
Date: Mon Jun 04 2018 - 17:33:40 EST


From: Salil Mehta <salil.mehta@xxxxxxxxxx>
Date: Mon, 4 Jun 2018 17:50:09 +0100

> From: Xi Wang <wangxi11@xxxxxxxxxx>
>
> If the multicast mask value in device tree is configured not all
> 0xff, the broadcast mac will be lost from tcam table after the
> execution of command 'ifconfig up'. The address is appended by
> hns_ae_start, but will be clear later by hns_nic_set_rx_mode
> called in dev_open process.
>
> This patch fixed it by not use the multicast mask when add a
> broadcast address.
>
> Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support")
> Signed-off-by: Xi Wang <wangxi11@xxxxxxxxxx>
> Signed-off-by: Peng Li <lipeng321@xxxxxxxxxx>
> Signed-off-by: Salil Mehta <salil.mehta@xxxxxxxxxx>
> ---
> Patch V2: Fixed comments by David Miller
> Link: https://lkml.org/lkml/2018/6/4/671
> Patch V1: Initial Submit

Applied and queued up for -stable, thank you.