Re: [PATCH 1/2] printk: remove unused flag LOG_NOCONS
From: Steven Rostedt
Date: Mon Jun 04 2018 - 17:33:53 EST
On Thu, 31 May 2018 14:16:33 +0200
Petr Mladek <pmladek@xxxxxxxx> wrote:
> > enum log_flags {
> > - LOG_NOCONS = 1, /* already flushed, do not print to console */
> > - LOG_NEWLINE = 2, /* text ended with a newline */
> > - LOG_PREFIX = 4, /* text started with a prefix */
> > - LOG_CONT = 8, /* text is a fragment of a continuation line */
> > + LOG_NEWLINE = 1, /* text ended with a newline */
> > + LOG_PREFIX = 2, /* text started with a prefix */
> > + LOG_CONT = 4, /* text is a fragment of a continuation line */
> > };
>
> Please, do not renumber the bits if there is no real need for it.
> The format of the log buffer is read also by external tool like
> "crash". It seems that "crash" ignores these flags but...
Then what's the problem for renumbering? I've renumbered internal flags
before. No one complained about it.
-- Steve