Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

[Mark Brown]

On Mon, Jun 11, 2018 at 03:11:14PM +0200, Linus Walleij wrote:

> The DT binding for "regulator-fixed" specifies that enable-active-high
> should be set for polarity inversion. For historical reasons, I guess,
> we screwed up. The example in the binding uses that.

No, it just says that if the enable is active high then we should
specify it using that boolean property.  It explicitly says that enables
might be active low:

| - enable-active-high: Polarity of GPIO is Active high
| If this property is missing, the default assumed is Active low.

This binding predates the GPIO binding having any gpiolib level polarity
inversion.

> Sadly this only handled the undocumented fixed
> regulator binding "reg-fixed-voltage". So I need to fix it
> for "regulator-fixed" as well, and then it "should work".

The normal fixed voltage regulator parses enable-active-high?

Attachment: signature.asc
Description: PGP signature