Re: [PATCH v7 2/4] random: Return nbytes filled from hw RNG

From: Andy Shevchenko
Date: Tue Jun 12 2018 - 04:40:07 EST


On Tue, Jun 12, 2018 at 3:39 AM, Tobin C. Harding <me@xxxxxxxx> wrote:
> Currently the function get_random_bytes_arch() has return value 'void'.
> If the hw RNG fails we currently fall back to using get_random_bytes().
> This defeats the purpose of requesting random material from the hw RNG
> in the first place.

> - int chunk = min(nbytes, (int)sizeof(unsigned long));
> + int chunk = min_t(int, left, (int)sizeof(unsigned long));

Isn't this (int) implied when you use min_t(int, ...) ?

--
With Best Regards,
Andy Shevchenko