Re: [PATCH] gpio: Fix wrong rounding in gpio-menz127

From: Linus Walleij
Date: Tue Jun 12 2018 - 04:40:39 EST


On Mon, Jun 4, 2018 at 3:58 PM, Nadav Amit <namit@xxxxxxxxxx> wrote:

> men_z127_debounce() tries to round up and down, but uses functions which
> are only suitable when the divider is a power of two, which is not the
> case. Use the appropriate ones.
>
> Found by static check. Compile tested.
>
> Fixes: f436bc2726c64 ("gpio: add driver for MEN 16Z127 GPIO controller")
>
> Signed-off-by: Nadav Amit <namit@xxxxxxxxxx>

Applied as a non-critical fix as I have not error reports.

Yours,
Linus Walleij