Re: [PATCH net] net: qcom/emac: Add missing of_node_put()

From: Timur Tabi
Date: Wed Jun 13 2018 - 16:45:12 EST


On 06/11/2018 08:03 AM, YueHaibing wrote:
Add missing of_node_put() call for device node returned by
of_parse_phandle().

Signed-off-by: YueHaibing<yuehaibing@xxxxxxxxxx>

Acked-by: Timur Tabi <timur@xxxxxxxxxxxxxx>

This seems legit. The comment for of_find_device_by_node() that says the np needs to be released was added after the code was written, so it's possible that I didn't know at the time that this was a requirement.

However, I no longer have the ability to test EMAC on device tree platforms, so I can't verify this code.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.