Re: [PATCH v5] Input: add bu21029 touch driver

From: Jonas Mark (BT-FIR/ENG1)
Date: Fri Jun 15 2018 - 10:26:27 EST


Hi Dmitry,

> > > > [PATCH v5] Input: add bu21029 touch driver
> > > >
> > > > Add Rohm BU21029 resistive touch panel controller support with I2C
> > > > interface.
> > >
> > > Is the patch ready to be pushed upstream? Is there anything I still need to do?
> >
> > I would like to kindly remind you of the BU21029 touch screen driver.
> > Could you please forward it to the mainline kernel?
>
> Sorry for the delay. Could you please tell me if the patch below (shoudl
> apply on top of your v5 version) works?

Yes, the patch works. We applied and compiled it with 4.14 and
4.17-rc3. We tested on our hardware with 4.14.

Only for 4.14 an #include <linux/regulator/consumer.h> was missing. I
Guess the API changed here a little in the meantime.

Because we do not have a controllable power supply on our board we see
the following complaint. But I think it is intentional and ok, right?

[ 1.715963] bu21029 0-0040: 0-0040 supply vdd not found, using dummy regulator
[ 1.723806] input: bu21029 as /devices/soc0/soc/2100000.aips-bus/21a0000.i2c/i2c-0/0-0040/input/input0

> + - vdd-supply : power supply for the controoler

There is a typo in controller.

What's the next step?

Greetings,
Mark

Building Technologies, Panel Software Fire (BT-FIR/ENG1)
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118
Aufsichtsratsvorsitzender: Stefan Hartung; Geschäftsführung: Gert van Iperen, Andreas Bartz, Thomas Quante, Bernhard Schuster