Re: [PATCH] locking/memory-barriers.txt/kokr: Update Korean translation to fix broken DMA vs. MMIO ordering example

[sjpark]

Hello Byungchul,


On Tue, 26 Jun 2018, Byungchul Park wrote:

> On Sun, Jun 17, 2018 at 02:16:08PM +0900, SeongJae Park wrote:
> > Translate this commit to Korean:
> >
> >   5846581e3563 ("locking/memory-barriers.txt: Fix broken DMA vs. MMIO ordering example")
>
> Hi SeongJae,
>
> You keep doing good jobs ;)
>
> I believe it would be better if you consider the little things below
> more. What do you think about it, SeongJae?

Thank you for great comments!

>
> > Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
> > ---
> >  Documentation/translations/ko_KR/memory-barriers.txt | 15 +++++++--------
> >  1 file changed, 7 insertions(+), 8 deletions(-)
> >
> > diff --git a/Documentation/translations/ko_KR/memory-barriers.txt b/Documentation/translations/ko_KR/memory-barriers.txt
> > index 921739d00f69..ada0a709cce1 100644
> > --- a/Documentation/translations/ko_KR/memory-barriers.txt
> > +++ b/Documentation/translations/ko_KR/memory-barriers.txt
> > @@ -1891,19 +1891,18 @@ Mandatory ëëìëì SMP ììíììë UP ììíììë SMP í
> >  		/* ììêì ìì */
> >  		desc->status = DEVICE_OWN;
> >
> > -		/* MMIO ë íí ëëììì êìë íê ìì ëëëë ëêí */
> > -		wmb();
> > -
> >  		/* ìëìíë ëìíëíì ëëììì êì */
> >  		writel(DESC_NOTIFY, doorbell);
> >  	}
> >
> >       dma_rmb() ë ëìíëíëëí ëìíë ìììê ìì ëëììê ììêì
> > -     ëëììì ëìíê íê, dma_wmb() ë ëëììê ììì ììêì ëì
> > -     êììì ëê ìì ëìíëíì ëìíê ìììì ëìíëë.  wmb() ë
> > -     ìì ìêìì ìë (cache incoherent) MMIO ììì ìêë ìëíê ìì
> > -     ìì ìêìì ìë ëëë (cache coherent memory) ìêê ìëëììì
> > -     ëìíìê ìí íìíëë.
> > +     ëëëìì êì ëìíê, dma_wmb() ë ëëììê ììì ììêì ëì
> > +     êììì ëê ìì ëìíëíì ëìíê ììì êì ëìíëë.  writel()
>                                                                         ^
>                                                                      ìêë,

Nice comment.  This will enhance the readability a lot.

>
> > +     ì ììíë ìì ìêìì ìë ëëë (cache coherent memory) ìêê MMIO
> > +     ìììì ìê ìì ìëëìì êì ëìíëë writel() ìì wmb() ë
> > +     ìíí íìê ììì ììëìê ëëëë.  writel() ëë ëìì ìëí
> > +     writel_relaxed() ë ìë ëìì ìêíì ììëë ìêì ììëì ììì
> > +     íëë.
> >
> >       consistent memory ì ëí ììí ëìì ìíì Documentation/DMA-API.txt
> >       ëìë ìêíìì.
>
>      See the subsection "Kernel I/O barrier effects" for more information on
>      relaxed I/O accessors and the Documentation/DMA-API.txt file for more
>      information on consistent memory.
>
> Don't you think the whole sentence need to be translated? If yes, then
> it would be better to do that as well ;)

Oh, my mistake!  It should be.

I applied your comments to the second version.


Thanks,
SeongJae Park

>
> > --
> > 2.13.0
>
> --
> Thanks,
> Byungchul
>