Re: [PATCH v2 0/2] Add a property in at24.c

[Bartosz Golaszewski]

2018-06-26 14:14 GMT+02:00 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:
> On Tue, 2018-06-26 at 09:41 +0200, Bartosz Golaszewski wrote:
>> 2018-06-26 8:22 GMT+02:00  <alanx.chiang@xxxxxxxxx>:
>> > From: "alanx.chiang" <alanx.chiang@xxxxxxxxx>
>> >
>> > In at24.c, it uses 8-bit addressing by default. In this patch,
>> > add a property address-width that provides a flexible method to
>> > pass the information to the driver.
>> >
>> > alanx.chiang (2):
>> >   dt-bindings: at24: Add address-width property
>> >   eeprom: at24: Add support for address-width property
>> >
>> >  Documentation/devicetree/bindings/eeprom/at24.txt |  2 ++
>> >  drivers/misc/eeprom/at24.c                        | 16
>> > ++++++++++++++++
>> >  2 files changed, 18 insertions(+)
>> >
>> > --
>> > 2.7.4
>> >
>>
>> What is your use case exactly? Do you have an EEPROM model that's not
>> yet supported explicitly in the driver? Why would you need this
>> option?
>
> The current at24 driver has no address width support, thus, reusing same
> (allocated) IDs (non-DT case) is hard.
>

Every supported compatible has the width already specified in its
corresponding chip data.

Bart