Re: [PATCH v3 3/3] console/fbcon: Add support for deferred console takeover

From: Andy Shevchenko
Date: Tue Jun 26 2018 - 14:49:40 EST


On Tue, Jun 26, 2018 at 9:29 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

>>> + for (i = 0; i < FB_MAX; i++) {
>>> + if (registered_fb[i])
>>> + fbcon_fb_registered(registered_fb[i]);
>>> + }

>> Simple git grep shows that we perhaps do
>>
>> #define for_each_registered_fbcon(i) ...
>>
>> (As an example see for_each_pci_bridge() how it's done there)
>
>
> This is probably a worthwhile cleanup for all the fbdev related
> code / drivers. But outside of the scope of this patchset.

True.

Yisheng, in case you are interested in doing such clean up...

--
With Best Regards,
Andy Shevchenko