Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode
From: Dan Williams
Date: Tue Jun 26 2018 - 14:52:57 EST
On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler
<ross.zwisler@xxxxxxxxxxxxxxx> wrote:
> QUEUE_FLAG_DAX is an indication that a given block device supports
> filesystem DAX and should not be set for PMEM namespaces which are in "raw"
> or "sector" modes. These namespaces lack struct page and are prevented
> from participating in filesystem DAX.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
> Suggested-by: Mike Snitzer <snitzer@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
Why is this cc: stable? What is the user visible impact of this change
especially given the requirement to validate QUEUE_FLAG_DAX with
bdev_dax_supported()? Patch looks good, but it's just a cosmetic fixup
afaics.