Re: [PATCH 2/2] sample/mdev/mbochs: add mbochs_kunmap_dmabuf
From: Alex Williamson
Date: Tue Jun 26 2018 - 22:01:27 EST
On Tue, 26 Jun 2018 09:32:33 +0200
Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
> > > .map = mbochs_kmap_dmabuf,
> > > + .unmap = mbochs_kunmap_dmabuf,
> > > .mmap = mbochs_mmap_dmabuf,
> > > };
> > >
> >
> > Is this a fix for v4.18?
>
> Yes.
>
> > AFAICT, the kmap_atomic removal is only in
> > next, not yet upstream and hopefully includes this sample driver before
> > hitting mainline. Should we therefore have a v4.18-rc based patch for
> > this to include before v4.18 to resolve this?
>
> The kmap_atomic interface will be removed in 4.19 because nobody uses
> it, so dropping the mbochs implementation already in 4.18 should not
> cause any issues.
>
> So just queue both for 4.18 would be the easiest way do deal with the
> dependency I think.
Ok, so I'll drop the fixes tag and apply both to my for-linus branch
for v4.18 and then Christian won't need to include it for the v4.19
patch. Thanks,
Alex