Re: [PATCH net-next] net: cavium: add missing PCI dependencies

[Alexander Sverdlin]

Hello Arnd,

On 17/07/18 15:46, Arnd Bergmann wrote:
> While some of the cavium drivers don't require PCI support, most
> others do, as shown by these build failures:

[...]

> This adds back the minimum set of dependencies to get everything to
> build cleanly again, but leaving the ones that build cleanly.
> 
> Fixes: 7e2bc7fb65d5 ("net: cavium: Drop dependency of NET_VENDOR_CAVIUM on PCI")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  drivers/net/ethernet/cavium/Kconfig | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig
> index 4c3a5c354497..80e2e93e4aad 100644
> --- a/drivers/net/ethernet/cavium/Kconfig
> +++ b/drivers/net/ethernet/cavium/Kconfig
> @@ -14,7 +14,7 @@ if NET_VENDOR_CAVIUM
>  
>  config THUNDER_NIC_PF
>  	tristate "Thunder Physical function driver"
> -	depends on 64BIT
> +	depends on 64BIT && PCI
>  	select THUNDER_NIC_BGX
>  	---help---
>  	  This driver supports Thunder's NIC physical function.
> @@ -27,7 +27,7 @@ config THUNDER_NIC_PF
>  config THUNDER_NIC_VF
>  	tristate "Thunder Virtual function driver"
>  	imply CAVIUM_PTP
> -	depends on 64BIT
> +	depends on 64BIT && PCI
>  	---help---
>  	  This driver supports Thunder's NIC virtual function
>  
> @@ -35,7 +35,7 @@ config	THUNDER_NIC_BGX
>  	tristate "Thunder MAC interface driver (BGX)"
>  	depends on 64BIT
>  	select PHYLIB
> -	select MDIO_THUNDER
> +	select MDIO_THUNDER if PCI
>  	select THUNDER_NIC_RGX
>  	---help---
>  	  This driver supports programming and controlling of MAC

I believe this hunk should look exactly as the previous one, i.e. 64BIT && PCI,
BGX itself depends on PCI as well. I've actually sent v2 to fix the above, but
got no reply on it up to now...

-- 
Best regards,
Alexander Sverdlin.