Re: [PATCH net-next] net: cavium: add missing PCI dependencies

[Arnd Bergmann]

On Tue, Jul 17, 2018 at 4:31 PM, Alexander Sverdlin
<alexander.sverdlin@xxxxxxxxx> wrote:

>> @@ -35,7 +35,7 @@ config      THUNDER_NIC_BGX
>>       tristate "Thunder MAC interface driver (BGX)"
>>       depends on 64BIT
>>       select PHYLIB
>> -     select MDIO_THUNDER
>> +     select MDIO_THUNDER if PCI
>>       select THUNDER_NIC_RGX
>>       ---help---
>>         This driver supports programming and controlling of MAC
>
> I believe this hunk should look exactly as the previous one, i.e. 64BIT && PCI,
> BGX itself depends on PCI as well.

That would work as well. My approach was to allow compiling that driver
with PCI because I got no build failures other than the MDIO_THUNDER
issues.

> I've actually sent v2 to fix the above, but got no reply on it up to now...

Your patch was applied into net-next already, so you need to send
a fix relative to your first patch rather than a replacement.

      Arnd