Re: m68k allmodconfig build errors

From: Randy Dunlap
Date: Mon Jul 23 2018 - 21:52:32 EST


On 07/20/2018 12:20 AM, Andreas Schwab wrote:
> On Jul 19 2018, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
>> block/partitions/ldm.o: In function `ldm_partition':
>> ldm.c:(.text+0x1900): undefined reference to `strcmp'
>> ldm.c:(.text+0x1964): undefined reference to `strcmp'
>> drivers/rtc/rtc-proc.o: In function `is_rtc_hctosys':
>> rtc-proc.c:(.text+0x290): undefined reference to `strcmp'
>> drivers/watchdog/watchdog_pretimeout.o: In function `watchdog_register_governor':
>> (.text+0x142): undefined reference to `strcmp'
>
> GCC has optimized strncmp to strcmp, but at a stage where macros are no
> longer available. I think the right fix is to use strcmp directly,
> since strncmp doesn't make sense here.

Hi Andreas,

I don't see that all of these string compare fields are null-terminated.

How does one convert strncmp() users to strcmp()?

thanks,
--
~Randy