Re: [PATCH 3/3] microblaze: add endianness options to LDFLAGS instead of LD
From: Masahiro Yamada
Date: Mon Jul 23 2018 - 21:54:18 EST
Hi Michal,
Ping?
2018-07-03 10:22 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
> With the recent syntax extension, Kconfig is now able to evaluate the
> compiler / toolchain capability.
>
> However, accumulating flags to 'LD' is not compatible with the way
> it works; 'LD' must be passed to Kconfig to call $(ld-option,...)
> from Kconfig files. If you tweak 'LD' in arch Makefile depending on
> CONFIG_CPU_BIG_ENDIAN, this would end up with circular dependency
> between Makefile and Kconfig.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>
> arch/microblaze/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile
> index d269dd4b..7333036 100644
> --- a/arch/microblaze/Makefile
> +++ b/arch/microblaze/Makefile
> @@ -40,11 +40,11 @@ CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_PCMP_INSTR) += -mxl-pattern-compare
> ifdef CONFIG_CPU_BIG_ENDIAN
> KBUILD_CFLAGS += -mbig-endian
> KBUILD_AFLAGS += -mbig-endian
> -LD += -EB
> +LDFLAGS += -EB
> else
> KBUILD_CFLAGS += -mlittle-endian
> KBUILD_AFLAGS += -mlittle-endian
> -LD += -EL
> +LDFLAGS += -EL
> endif
>
> CPUFLAGS-1 += $(call cc-option,-mcpu=v$(CPU_VER))
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada