Re: [PATCH v2] tracing/kprobes: Fix trace_probe flags on enable_trace_kprobe() failure

[Steven Rostedt]

On Thu, 26 Jul 2018 00:41:13 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> On Wed, 25 Jul 2018 16:20:38 +0200
> Artem Savkov <asavkov@xxxxxxxxxx> wrote:
> 
> > If enable_trace_kprobe fails to enable the probe in enable_k(ret)probe
> > it returns an error, but does not unset the tp flags it set previously.
> > This results in a probe being considered enabled and failures like being
> > unable to remove the probe through kprobe_events file since probes_open()
> > expects every probe to be disabled.
> >   
> 
> Looks good to me.
> 
> Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thanks Masami,

-- Steve