Re: [PATCH v2] tracing/kprobes: Fix trace_probe flags on enable_trace_kprobe() failure

[Steven Rostedt]

On Wed, 25 Jul 2018 10:35:57 -0500
Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> On Wed, Jul 25, 2018 at 04:20:38PM +0200, Artem Savkov wrote:
> > If enable_trace_kprobe fails to enable the probe in enable_k(ret)probe
> > it returns an error, but does not unset the tp flags it set previously.
> > This results in a probe being considered enabled and failures like being
> > unable to remove the probe through kprobe_events file since probes_open()
> > expects every probe to be disabled.
> > 
> > Signed-off-by: Artem Savkov <asavkov@xxxxxxxxxx>  
> 
> Reviewed-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> 

Thanks Josh!

Queued up and currently being tested.

-- Steve