Re: [REPOST PATCH 4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms

[Minas Harutyunyan]

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on stm32f4x9_fsotg since commit
> e35b135055e2 ("usb: dwc2: Add support for STM32F429/439/469 USB OTG
> HS/FS in FS mode (internal PHY)").  That commit is pretty recent, so
> it's unclear to me why the uframe scheduler was left off.  Hopefully
> it's because someone copied it from other parameters and didn't think
> to try it?
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Reviewed-by: Minas Harutyunyan <hminas@xxxxxxxxxxxx>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 93380f7c32b4..7be35bcde713 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -131,7 +131,6 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
>   	p->max_packet_count = 256;
>   	p->phy_type = DWC2_PHY_TYPE_PARAM_FS;
>   	p->i2c_enable = false;
> -	p->uframe_sched = false;
>   	p->activate_stm_fs_transceiver = true;
>   }
>   
>