Re: [PATCH net-next] rxrpc: remove redundant variables 'xcall','sp' and 'did_discard'

[YueHaibing]

On 2018/8/1 16:28, David Howells wrote:
> YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
> 
>>  		while (*pp) {
>>  			parent = *pp;
>> -			xcall = rb_entry(parent, struct rxrpc_call, sock_node);
>>  			if (user_call_ID < call->user_call_ID)
>>  				pp = &(*pp)->rb_left;
>>  			else if (user_call_ID > call->user_call_ID)
> 
> No, this is an actual bug.  The if-conditions should be using xcall-> not
> call->.

yes, I will post a new patch, thanks.

> 
>> -		sp = rxrpc_skb(skb);
> 
> Yeah, that's fine.
> 
>> -	did_discard = true;
> 
> Hmmm...  It looks like I intended something with this, but I don't remember
> what now.  I think it can be removed.
> 
> David
> 
> .
>