Re: [PATCH RESEND 1/2] staging: erofs: add the missing break in z_erofs_map_blocks_iter

From: Gao Xiang
Date: Wed Aug 01 2018 - 08:09:08 EST


Hi Dan,

On 2018/8/1 19:36, Dan Carpenter wrote:
> On Wed, Aug 01, 2018 at 05:36:54PM +0800, Gao Xiang wrote:
>> This patch adds a missing break after adding the default case.
>>
>> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>
>> Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx>
>> ---
>> As pointed out by Dan Carpenter:
>> - fix the wrong place of fallthrough comments
> Thanks. Looks good. Next time use [PATCH v2] instead of RESEND. The
> word RESEND basically means you are resending a patch exactly the same
> as it was before. You would only need to do that if we accidentally
> deleted your first patch or whatever...
>
> regards,
> dan carpenter
>
>
OK, it should not be titled RESEND, and I will take care the next time.
Thanks for taking the time to review :)

Thanks,
Gao Xiang