Re: [PATCH 1/4] driver/scsi/fnic/fnic_trace: Use vzalloc to zero instead of vmalloc+memset

From: Andy Shevchenko
Date: Wed Aug 01 2018 - 11:31:02 EST


On Wed, Aug 1, 2018 at 4:26 PM, zhong jiang <zhongjiang@xxxxxxxxxx> wrote:
> The vzalloc is better than vmalloc+memset, so replace them to make
> the code concise.

> - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
> + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * PAGE_SIZE));

At the same time you may get rid of unnecessary parens.

--
With Best Regards,
Andy Shevchenko