Re: [PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures

From: Christoph Hellwig
Date: Thu Aug 02 2018 - 12:03:43 EST


s/codes/code/ in the subject. Also a little explanation of why
you refactor it in the patch description would be helpful.

> +static long restore_fp_state(struct pt_regs *regs,
> + union __riscv_fp_state *sc_fpregs)

Please add another tab for the indentation here even if the original
code got it wrong.

> +static long save_fp_state(struct pt_regs *regs,
> + union __riscv_fp_state *sc_fpregs)

Same here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>