Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"

From: zhong jiang
Date: Sun Aug 05 2018 - 22:15:37 EST


On 2018/8/6 8:33, David Miller wrote:
> From: zhong jiang <zhongjiang@xxxxxxxxxx>
> Date: Sun, 5 Aug 2018 22:18:43 +0800
>
>> @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br,
>> struct sk_buff *skb_trimmed = NULL;
>> const unsigned char *src;
>> struct igmphdr *ih;
>> - int err;
>> + int err = 0;
>>
>> err = ip_mc_check_igmp(skb, &skb_trimmed);
> The initialization of err to '0' is unnecessary, it gets assigned on
> the very next line.
>
> .
>
That's right. I will drop that change and repost.

Thanks,
zhong jiang