Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"

From: David Miller
Date: Sun Aug 05 2018 - 20:33:40 EST


From: zhong jiang <zhongjiang@xxxxxxxxxx>
Date: Sun, 5 Aug 2018 22:18:43 +0800

> @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br,
> struct sk_buff *skb_trimmed = NULL;
> const unsigned char *src;
> struct igmphdr *ih;
> - int err;
> + int err = 0;
>
> err = ip_mc_check_igmp(skb, &skb_trimmed);

The initialization of err to '0' is unnecessary, it gets assigned on
the very next line.