RE: [PATCH] x86/irqflags: provide a declaration for native_save_fl

From: David Laight
Date: Mon Aug 06 2018 - 06:23:38 EST


From: Nick Desaulniers
> Sent: 03 August 2018 18:06
> Fixes commit d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern
> inline").
>
> It was reported that the above commit was causing users of gcc < 4.9 to
> observe -Werror=missing-prototypes errors.
>
> Indeed, it seems that:
> extern inline unsigned long native_save_fl(void) { return 0; }
>
> compiled with -Werror=missing-prototypes produces this warning in gcc <
> 4.9, but not gcc >= 4.9.
>
> Cc: stable@xxxxxxxxxxxxxxx # 4.17, 4.14, 4.9, 4.4
> Reported-by: David Laight <david.laight@xxxxxxxxxx>
> Reported-by: Jean Delvare <jdelvare@xxxxxxx>
> Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

You can add my:

Tested-by: David Laight <david.laight@xxxxxxxxx>

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)