Re: [PATCH] x86/irqflags: provide a declaration for native_save_fl

From: Sedat Dilek
Date: Mon Aug 06 2018 - 06:38:32 EST


On Mon, Aug 6, 2018 at 12:25 PM, David Laight <David.Laight@xxxxxxxxxx> wrote:
> From: Nick Desaulniers
>> Sent: 03 August 2018 18:06
>> Fixes commit d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern
>> inline").
>>
>> It was reported that the above commit was causing users of gcc < 4.9 to
>> observe -Werror=missing-prototypes errors.
>>
>> Indeed, it seems that:
>> extern inline unsigned long native_save_fl(void) { return 0; }
>>
>> compiled with -Werror=missing-prototypes produces this warning in gcc <
>> 4.9, but not gcc >= 4.9.
>>
>> Cc: stable@xxxxxxxxxxxxxxx # 4.17, 4.14, 4.9, 4.4
>> Reported-by: David Laight <david.laight@xxxxxxxxxx>
>> Reported-by: Jean Delvare <jdelvare@xxxxxxx>
>> Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
>
> You can add my:
>
> Tested-by: David Laight <david.laight@xxxxxxxxx>
>

Tested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>

On top of Linux v4.18-rc8 with clang version 7.0.0-svn338205.

- sed@ -