Re: [PATCH v2 2/3] x86/mm: add .data..decrypted section to hold shared variables

[Brijesh Singh]

Hi Boris,


On 08/29/2018 08:59 AM, Borislav Petkov wrote:

...

> >   static void __init __sme_map_range_pmd(struct sme_populate_pgd_data *ppd)
> > @@ -235,6 +235,11 @@ static void __init sme_map_range_encrypted(struct sme_populate_pgd_data *ppd)
> >   	__sme_map_range(ppd, PMD_FLAGS_ENC, PTE_FLAGS_ENC);
> >   }
> >   
> > +static void __init sme_map_range_encrypted_wp(struct sme_populate_pgd_data *ppd)
> > +{
> > +	__sme_map_range(ppd, PMD_FLAGS_ENC_WP, PTE_FLAGS_ENC_WP);
> > +}
> > +
> >   static void __init sme_map_range_decrypted(struct sme_populate_pgd_data *ppd)
> >   {
> >   	__sme_map_range(ppd, PMD_FLAGS_DEC, PTE_FLAGS_DEC);
>
> These changes with the _WP flags and helper addition belong in a pre-patch.


Please note that the _WP flags and helper functions are used by this
patch only. Introducing a helper in a separate patch will cause a build
warning. I am leaning to keep the helper in this patch but if you think
it should be done in separate patch then let me know.


-Brijesh