Re: [PATCH v2 2/3] x86/mm: add .data..decrypted section to hold shared variables
From: Borislav Petkov
Date: Thu Aug 30 2018 - 05:22:28 EST
On Wed, Aug 29, 2018 at 10:54:37AM -0500, Brijesh Singh wrote:
> Please note that the _WP flags and helper functions are used by this
> patch only. Introducing a helper in a separate patch will cause a build
> warning.
... a build warning which goes away with the next patch, adding the
users, right?
> I am leaning to keep the helper in this patch but if you think
> it should be done in separate patch then let me know.
Well, if you're doing a bunch of different things in a single patch, it
would be better, IMO, to have each thing in a separate patch.
Thx.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--