Re: [linux-sunxi] [PATCH v3 21/30] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor

From: Philipp Rossak
Date: Thu Aug 30 2018 - 16:47:05 EST

On 30.08.2018 22:00, Philipp Rossak wrote:
On 30.08.2018 18:27, OndÅej Jirman wrote:
+static int sun8i_h3_calibrate(struct sun4i_gpadc_iio *info)
+//ÂÂÂ regmap_write(info->regmap, SUNXI_THS_CDATA_0_1,
+//ÂÂÂÂÂÂÂÂÂÂÂ info->calibration_data[0]);
+//ÂÂÂ regmap_write(info->regmap, SUNXI_THS_CDATA_2_3,
+//ÂÂÂÂÂÂÂÂÂÂÂ info->calibration_data[1]);
This should probably be implemented, or left out completely.

ÂÂ o.

Thanks you are right!
This should be implemented! I will fix this in the next version!


I just realized this function need to check if calibration datas are available. Writing zeros to the calibration data regs "breaks" the thermal sensor.