Re: [PATCH V3 13/26] csky: Library functions

[Guo Ren]

On Thu, Sep 06, 2018 at 05:50:02PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 6, 2018 at 4:25 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > On Wed, Sep 5, 2018 at 2:08 PM Guo Ren <ren_guo@xxxxxxxxx> wrote:
> > > --- /dev/null
> > > +++ b/arch/csky/abiv1/memset.c
> > > @@ -0,0 +1,38 @@

> > > +       if ((long)d & 0x3)
> > > +               while (l--) *d++ = ch;
> 
> while ((uintptr_t)d & 0x3) && l--)
>         *d++ =ch;
> 
> and remove the else below?
Ok
 
> > > +                       *(((long *)d)+3) = tmp;
> 
> s/long/u32/
Ok

Thx
 Guo Ren