Re: [PATCH V3 17/26] csky: Misc headers

[Guo Ren]

On Thu, Sep 06, 2018 at 04:16:30PM +0200, Arnd Bergmann wrote:
> On Wed, Sep 5, 2018 at 2:08 PM Guo Ren <ren_guo@xxxxxxxxx> wrote:
> 
> > diff --git a/arch/csky/boot/dts/qemu.dts b/arch/csky/boot/dts/qemu.dts
> > new file mode 100644
> > index 0000000..d36e4cd
> > --- /dev/null
> > +++ b/arch/csky/boot/dts/qemu.dts
> > @@ -0,0 +1,77 @@
> > +/dts-v1/;
> > +/ {
> > +       compatible = "csky,qemu";
> > +       #address-cells = <1>;
> > +       #size-cells = <1>;
> > +       interrupt-parent = <&intc>;
> 
> Ideally, qemu would supply a dtb file that matches the current configuration,
> as we do for instance on the ARM 'virt' machine. This allows you
> much more flexibility in running all kinds of options, as well as extending
> qemu later with new features.
So, I should remove qemu.dts in next version patch?

> > +
> > +               timer0: timer@0xffffd000 {
> > +                       compatible = "snps,dw-apb-timer";
> > +                       reg = <0xffffd000 0x1000>;
> > +                       clocks = <&dummy_apb>;
> > +                       clock-names = "timer";
> > +                       interrupts = <1>;
> > +               };
> > +
> > +               timer1: timer@0xffffd014 {
> 
> Drop the leading '0x' in the unit-address here (in all devices)
Ok