Re: [PATCH v3 2/2] dt-bindings: pinctrl: qcom: Add SDM660 pinctrl binding

[Bjorn Andersson]

On Tue 25 Sep 10:38 PDT 2018, Craig Tatlor wrote:
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
[..]
> +- reg:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: the base address and size of the TLMM register space.

This should mention that we're expecting address and size of the three
tiles. And the proposed patches depends on reg-names for the lookup.

> +
[..]
> +Example:
> +
> +	tlmm: pinctrl@1010000 {
> +		compatible = "qcom,sdm660-pinctrl";
> +		reg = <0x1010000 0x300000>;

reg (and the node address) needs to be updated.

> +		interrupts = <0 208 0>;

		interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;

> +		gpio-controller;
> +		gpio-ranges = <&tlmm 0 0 114>;
> +		#gpio-cells = <2>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +	};

Regards,
Bjorn